Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparing against nothing should be done with === #336

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Comparing against nothing should be done with === #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/GAPJulia/JuliaInterface/example/orbits.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ function bahn( element, generators, action )
for g in generators
c = action(b, g)
x = get(dict, c, nothing)
if x == nothing
if x === nothing
push!( orb, c )
dict[c] = length(orb)
end
Expand Down
2 changes: 1 addition & 1 deletion src/ccalls.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ function getproperty(funcobj::GlobalsType, name::Symbol)

v = ccall(:ValGVar, Ptr{Cvoid}, (Cuint,), gvar)
v = RAW_GAP_TO_JULIA(v)
if v == nothing
if v === nothing
error("GAP variable ", name, " not bound")
end
return v
Expand Down
2 changes: 1 addition & 1 deletion src/julia_to_gap.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ function julia_to_gap(obj::Array{T,1}, recursive::Val{Recursive}=Val(false), rec
end
for i in 1:len
x = obj[i]
if x == nothing
if x === nothing
continue
end
if Recursive
Expand Down