suppress the GAP banner when importing GAP.jl #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
==========================================
- Coverage 77.82% 76.91% -0.91%
==========================================
Files 59 59
Lines 4432 4441 +9
==========================================
- Hits 3449 3416 -33
- Misses 983 1025 +42
|
This pull request addresses issue oscar-system#334. - By default, `using GAP` will not show the banner. - If Julia's `ENV[ "GAP_SHOW_BANNER" ]` is set to `"true"` then the GAP banner is shown on `using GAP`. - When the user loads GAP packages, it depends on the `LoadPackage` call whether a package banner is shown. This is the standard GAP behaviour in the situation that banners are in principle enabled: If there is a second argument `false` then the banner is not shown, otherwise it is shown. (The idea is to set the command line option `-b` when GAP shall be started without banner, and to reset this option after the start of GAP.) I think we should wait until issue oscar-system#333 gets resolved before switching off the GAP banner by default.
ThomasBreuer
force-pushed
the
TB_suppress_banner
branch
from
24c7d46 to
4494321
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #334.
using GAPwill not show the banner.ENV[ "GAP_SHOW_BANNER" ]is set to"true"thenthe GAP banner is shown on
using GAP.LoadPackagecallwhether a package banner is shown.
This is the standard GAP behaviour in the situation that banners are
in principle enabled:
If there is a second argument
falsethen the banner is not shown,otherwise it is shown.
(The idea is to set the command line option
-bwhen GAP shall be startedwithout banner, and to reset this option after the start of GAP.)
I think we should wait until issue #333 gets resolved
before switching off the GAP banner by default.