Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let Documenter.jl test Julia examples #358

Merged
merged 2 commits into from
Mar 5, 2020

Conversation

ThomasBreuer
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #358 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #358   +/-   ##
=======================================
  Coverage   77.78%   77.78%           
=======================================
  Files          58       58           
  Lines        3998     3998           
=======================================
  Hits         3110     3110           
  Misses        888      888
Impacted Files Coverage Δ
src/macros.jl 100% <ø> (ø) ⬆️
src/utils.jl 62.5% <ø> (ø) ⬆️

Project.toml Outdated
@@ -4,6 +4,7 @@ authors = ["Thomas Breuer <[email protected]>", "Sebastian Gutsche <gutsch
version = "0.2.6"

[deps]
Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we only need this for tests, we should instead add it to the [extras] section, shouldn't we?

@ThomasBreuer ThomasBreuer force-pushed the TB_Documenter_tests branch 2 times, most recently from 009d933 to ee00bac Compare March 5, 2020 14:44
added corresponding line to .travis.yml,
added "Documenter" to targets,
and rebased, in order to have a chance that the tests with Julia 1.1 pass
@ThomasBreuer ThomasBreuer force-pushed the TB_Documenter_tests branch from ee00bac to 3c4e2b0 Compare March 5, 2020 16:05
@ThomasBreuer ThomasBreuer merged commit 407563c into oscar-system:master Mar 5, 2020
@ThomasBreuer ThomasBreuer deleted the TB_Documenter_tests branch March 5, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants