Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify package initialization #362

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Conversation

fingolfin
Copy link
Member

No description provided.

@fingolfin fingolfin requested a review from ThomasBreuer March 5, 2020 16:04
@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #362 into master will decrease coverage by 0.13%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
- Coverage   77.78%   77.65%   -0.14%     
==========================================
  Files          58       58              
  Lines        3998     3952      -46     
==========================================
- Hits         3110     3069      -41     
+ Misses        888      883       -5
Impacted Files Coverage Δ
src/GAP.jl 93.87% <100%> (-0.47%) ⬇️
pkg/GAPJulia/JuliaExperimental/julia/gapperm.jl 88.14% <0%> (-0.75%) ⬇️
pkg/GAPJulia/JuliaExperimental/julia/loewy.jl 84.01% <0%> (-0.27%) ⬇️
src/ccalls.jl 98.38% <0%> (-0.06%) ⬇️
src/julia_to_gap.jl 95.52% <0%> (+1.31%) ⬆️
src/packages.jl 94.73% <0%> (+4.73%) ⬆️

Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

@fingolfin fingolfin merged commit b56c4ad into oscar-system:master Mar 5, 2020
@fingolfin fingolfin deleted the mh/init branch March 5, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants