Switch to GAP 4.11.0 point release #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #364 +/- ##
==========================================
+ Coverage 77.77% 77.84% +0.07%
==========================================
Files 58 59 +1
Lines 3995 4433 +438
==========================================
+ Hits 3107 3451 +344
- Misses 888 982 +94
|
fingolfin
force-pushed
the
mh/gap-4.11.0
branch
3 times, most recently
from
d215c38 to
46e3b06
Compare
ThomasBreuer
approved these changes
Mar 6, 2020
deps/build.jl
Outdated
| cd("gap") | ||
| run(`./autogen.sh`) | ||
| run(`rm -rf gap-$(gap_version)`) | ||
| filename = download("https://www.gap-system.org/pub/gap/gap-4.11/tar.bz2/gap-$(gap_version).tar.bz2") |
There was a problem hiding this comment.
Can we avoid the hard-coded 4.11 in this line (and in etc/travis_install_gap.sh)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This actually renders a few other PRs superfluous.
Resolves #306
Resolves #316
Closes #321
Resolves #351
Closes #361