Remove Base.big(obj::GapObj)
#763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #763 +/- ##
==========================================
- Coverage 78.15% 78.12% -0.04%
==========================================
Files 46 46
Lines 3644 3639 -5
==========================================
- Hits 2848 2843 -5
Misses 796 796
|
|
One concern is that this formally breaks the ABI, so it should go into 0.8.0. |
ThomasBreuer
reviewed
Dec 3, 2021
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## Version 0.7.3-DEV (released 2021-XYZ) | |||
|
|
|||
| - Remove `Base.big(obj::GapObj)`: nothing was using it and it does not really | |||
| fit conceptually into this package. | |||
There was a problem hiding this comment.
This depends on what GAP.jl means. If it is a service package for Oscar then big is not interesting, if it is a low level interface between GAP and Julia then the situation is perhaps different.
(I am not arguing against removing the big method.)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.