Remove OverrideTypeNameAndModule hack #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that type `GapObj` is no longer printed as `GapObj` resp. `GAP.GapObj` (depending on context) but rather as `GAP_jll.GapObj`. But it avoids a deep hack in the Julia kernel that could cause lots of pain for us in the future.
fingolfin
force-pushed
the
mh/remove-OverrideTypeNameAndModule
branch
from
2532974 to
169139d
Compare
Codecov Report
@@ Coverage Diff @@
## master #805 +/- ##
==========================================
- Coverage 78.07% 78.07% -0.01%
==========================================
Files 46 46
Lines 3649 3648 -1
==========================================
- Hits 2849 2848 -1
Misses 800 800
|
|
I discussed this with @ThomasBreuer and we'll go this way: it's just not worth the ongoing hassle to try to keep this "feature" (i.e., slightly "nicer" (???)) printing of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that type
GapObjis no longer printed asGapObjresp.GAP.GapObj(depending on context) but rather asGAP_jll.GapObj.But it avoids a deep hack in the Julia kernel that could cause lots
of pain for us in the future.
Closes #804 (for which this PR is an alternative)