Update to latest GAP_jll / GAP_lib_jll #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #806 +/- ##
=======================================
Coverage 78.04% 78.04%
=======================================
Files 46 46
Lines 3644 3644
=======================================
Hits 2844 2844
Misses 800 800 |
|
The GAP.jl tests already ran successfully on macos nightly here (with the new jll versions): https://github.com/oscar-system/GAP.jl/runs/6092924646?check_suite_focus=true#step:6:308 |
|
Great! Yes, 0.8 is incompatible. So the plan is to release it soon and then submit an Oscar.jl PR to match, and finally make a new Oscar release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes gap-system/gap#4863 which removes the problematic
waitpidcalls. Let's see if that helpsCC @benlorenz