extend the julia_to_gap documentation
#824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by the explicit list of types for which conversions are provided in GAP.jl (the list which was already in the JuliaInterface manual)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #824 +/- ##
=======================================
Coverage 78.03% 78.03%
=======================================
Files 48 48
Lines 3687 3687
=======================================
Hits 2877 2877
Misses 810 810
|
fingolfin
reviewed
Sep 14, 2022
| @@ -24,6 +24,24 @@ julia> GAP.julia_to_gap([ [1, 2], [3, 4]], recursive = true) | |||
| GAP: [ [ 1, 2 ], [ 3, 4 ] ] | |||
|
|
|||
| ``` | |||
|
|
|||
| The following `julia_to_gap` conversions are supported by GAP.jl. | |||
There was a problem hiding this comment.
What about the other direction? Are we actually "symmetric" in what we support? Might be good to state, too?
There was a problem hiding this comment.
Yes, of course the other direction makes sense. If you think the current proposal is more or less o.k. for julia_to_gap then I will update it to include also the other direction.
fingolfin
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by the explicit list of types for which conversions are provided in GAP.jl (the list which was already in the JuliaInterface manual)
This addresses issue #823.