Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added "the" Rubik's cube example #839

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

ThomasBreuer
Copy link
Member

@ThomasBreuer ThomasBreuer commented Nov 8, 2022

Resolves #838.

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #839 (4ceb73f) into master (0de98ff) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #839   +/-   ##
=======================================
  Coverage   81.57%   81.57%           
=======================================
  Files          48       48           
  Lines        3653     3653           
=======================================
  Hits         2980     2980           
  Misses        673      673           

- exclude those session pieces from the doctests that involve
  random computations in GAP
- call `GAP.Globals.ComplementClassesRepresentatives` instead of
  `GAP.Globals.Complementclasses`
- renamed the variable `hom` to `fhom`
  (If Hecke.jl is loaded then `hom` is write protected.)
@fingolfin fingolfin merged commit f4c5914 into oscar-system:master Nov 10, 2022
@ThomasBreuer ThomasBreuer deleted the TB_rubik_example branch November 10, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: add some non-trivial examples for how to use GAP.jl
2 participants