admit prescribing a package version ... #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... in `GAP.Packages.install`. This is meanwhile supported by GAP's PackageManager package. The most interesting application is perhaps `GAP.Packages.load` with argument `install = true`, because now we can ask for loading a good enough version of a perhaps previously not installed package, and get `false` if this is not possible. (Also fixed now: `GAP.Packages.load` had returned `fail` in some situations, now `false` is returned in these cases.)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #847 +/- ##
==========================================
+ Coverage 81.46% 81.60% +0.13%
==========================================
Files 48 48
Lines 3664 3664
==========================================
+ Hits 2985 2990 +5
+ Misses 679 674 -5
|
fingolfin
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... in
GAP.Packages.install.This is meanwhile supported by GAP's PackageManager package.
The most interesting application is perhaps
GAP.Packages.loadwith argumentinstall = true, because now we can ask for loading a good enough version of a perhaps previously not installed package, and getfalseif this is not possible.(Also fixed now:
GAP.Packages.loadhad returnedfailin some situations, nowfalseis returned in these cases.)Resolves issue #627.