Allow passing a path to GAP.Packages.load
#893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addresses issue oscar-system#892
(but these are still not enough)
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #893 +/- ##
==========================================
+ Coverage 75.65% 75.84% +0.19%
==========================================
Files 51 51
Lines 4115 4157 +42
==========================================
+ Hits 3113 3153 +40
- Misses 1002 1004 +2
|
fingolfin
approved these changes
Jun 19, 2023
src/packages.jl
Outdated
| #TODO: What shall happen when `spec` is a symbolic link that points to | ||
| # the installation path of the loaded package? | ||
|
|
||
| # Call `Wrappers.SetPackagePath`. |
There was a problem hiding this comment.
The comment which indicates Wrappers.SetPackagePath is about to be called comes 7 lines before the actual call, that seems odd?
Suggested change
| # Call `Wrappers.SetPackagePath`. |
|
Two tests with Julia nightly were cancelled after about 18 minutes. The output of "Julia nightly - ubuntu-latest" looks as if the tests were started but did not make progress. (See #905.) Here is the log. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses issue #892