Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote @gap and g_str results #904

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Conversation

fingolfin
Copy link
Member

This way they get executed when the code containing them is executed, and not already during parse time, which is unexpected.

Resolves #903

CC @kalmarek

@fingolfin fingolfin requested a review from ThomasBreuer June 19, 2023 10:23
This way they get executed when the code containing them is executed,
and not already during parse time, which is unexpected.
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Merging #904 (fd15bad) into master (4aa758d) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #904   +/-   ##
=======================================
  Coverage   75.65%   75.65%           
=======================================
  Files          51       51           
  Lines        4115     4115           
=======================================
  Hits         3113     3113           
  Misses       1002     1002           
Impacted Files Coverage Δ
src/macros.jl 98.46% <100.00%> (ø)

@fingolfin fingolfin merged commit 4122bb3 into oscar-system:master Jun 19, 2023
@fingolfin fingolfin deleted the mh/fix-macros branch June 19, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@gap and g_str macro call evalstr at parsetime instead of runtime, which is surprising
1 participant