Only load bare deps if env var GAP_BARE_DEPS is set #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #912 +/- ##
==========================================
- Coverage 75.58% 75.56% -0.02%
==========================================
Files 51 51
Lines 4165 4170 +5
==========================================
+ Hits 3148 3151 +3
- Misses 1017 1019 +2
|
ThomasBreuer
approved these changes
Jul 6, 2023
| @@ -286,6 +286,9 @@ function __init__() | |||
| push!(cmdline_options, "-b") | |||
| end | |||
|
|
|||
| if haskey(ENV, "GAP_BARE_DEPS") | |||
| push!(cmdline_options, "-A") | |||
There was a problem hiding this comment.
I had expected that push!(cmdline_options, "--bare") would be enough, that is, the change in gap/systemfile.g would not be necessary. However, apparently then loading JuliaInterface causes problems. Thus the proposed changes seem to be a good solution for the moment.
There was a problem hiding this comment.
Yeah I first tried --bare, too, but then it didn't load JuliaInterface either. Hence this solution now. (Besides, we still might want to always load e.g. GAPDoc... well, we definitely will want to load it and also smallgrp, transgrp, primgrap and a bunch more in Oscar.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may or may not become default in a future (breaking) release. But for now it is simply useful for debugging the
GAP_pkg_*work at https://github.com/oscar-system/GAP_pkg