Ensure Ncurses_jll is new enough #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 6.4.1 it sets TERMINFO_DIRS automatically, so we can get rid of our workaround for setting it before loading GAP. That workaround was always incomplete anyway, because while it worked for GAP's builtin GNU readline support, it is also needed for the `Browse` packages. But for that it only works if `Browse` is loaded during GAP startup, which is not always the case: with a fresh GAP.jl installation, won't have been compiled yet. The user may now try to compile/install it via `GAP.Packages.install` resp. `GAP.Packages.load`. All kinds of things can go wrong at that point (including that it may end up linking against the "wrong"). Note that we do not even load `Ncurses_jll` directly; this is done indirectly via `GAP_jll`. So the only reason it now appears in `Project.toml` is to ensure a "new enough" version of it is used. At some point in the future this should probably instead be moved to `GAP_jll`.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #913 +/- ##
==========================================
- Coverage 75.58% 75.56% -0.03%
==========================================
Files 51 51
Lines 4162 4162
==========================================
- Hits 3146 3145 -1
- Misses 1016 1017 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 6.4.1 it sets TERMINFO_DIRS automatically, so we can get rid of
our workaround for setting it before loading GAP.
That workaround was always incomplete anyway, because while it worked
for GAP's builtin GNU readline support, it is also needed for the
Browsepackages. But for that it only works ifBrowseis loadedduring GAP startup, which is not always the case: with a fresh GAP.jl
installation, won't have been compiled yet. The user may now try to
compile/install it via
GAP.Packages.installresp.GAP.Packages.load.All kinds of things can go wrong at that point (including that it may
end up linking against the "wrong").
Note that we do not even load
Ncurses_jlldirectly; this is doneindirectly via
GAP_jll. So the only reason it now appears inProject.tomlis to ensure a "new enough" version of it is used. Atsome point in the future this should probably instead be moved to
GAP_jll.