Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify JuliaToGAP methods #938

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

fingolfin
Copy link
Member

Avoid using CallJuliaFunctionWithKeywordArguments

Avoid using CallJuliaFunctionWithKeywordArguments
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #938 (075dc47) into master (b216185) will increase coverage by 0.09%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
+ Coverage   75.64%   75.74%   +0.09%     
==========================================
  Files          51       51              
  Lines        4171     4151      -20     
==========================================
- Hits         3155     3144      -11     
+ Misses       1016     1007       -9     
Files Changed Coverage
pkg/JuliaInterface/gap/convert.gi 75.00%

Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.
(First I had thought that CallJuliaFunctionWithKeywordArguments could disappear, but no, just the better syntax for julia_to_gap allows us to avoid it here.)

@fingolfin fingolfin merged commit 1ad0308 into oscar-system:master Sep 18, 2023
@fingolfin fingolfin deleted the mh/simplify-GAP-conversion branch September 18, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants