Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize GAP function calls #948

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

fingolfin
Copy link
Member

Before:

julia> g=GAP.evalstr("(1,2)"); func = GAP.Globals.POW;

julia> @btime func(2,g);
  111.728 ns (3 allocations: 64 bytes)

After:

julia> g=GAP.evalstr("(1,2)"); func = GAP.Globals.POW;

julia> @btime func(2,g);
  26.508 ns (0 allocations: 0 bytes)

Before:

    julia> g=GAP.evalstr("(1,2)"); func = GAP.Globals.POW;

    julia> @Btime func(2,g);
      111.728 ns (3 allocations: 64 bytes)

After:

    julia> g=GAP.evalstr("(1,2)"); func = GAP.Globals.POW;

    julia> @Btime func(2,g);
      26.508 ns (0 allocations: 0 bytes)
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #948 (a2ad5b0) into master (5aa8c47) will decrease coverage by 0.16%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #948      +/-   ##
==========================================
- Coverage   75.68%   75.52%   -0.16%     
==========================================
  Files          51       51              
  Lines        4166     4168       +2     
==========================================
- Hits         3153     3148       -5     
- Misses       1013     1020       +7     
Files Coverage Δ
src/ccalls.jl 99.19% <100.00%> (+0.01%) ⬆️

... and 4 files with indirect coverage changes

@fingolfin fingolfin merged commit 3cfb342 into oscar-system:master Oct 13, 2023
@fingolfin fingolfin deleted the mh/optimize-calls branch October 13, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant