Add @gapproperty
#974
Add @gapproperty
#974
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #974 +/- ##
==========================================
+ Coverage 75.80% 75.85% +0.05%
==========================================
Files 51 51
Lines 4187 4196 +9
==========================================
+ Hits 3174 3183 +9
Misses 1013 1013
|
There was a problem hiding this comment.
First off, thank you for your contribution!
However, I recommend that next time we have a quick chat before you tackle one of these -- because in this case, re-reading issue #680, today my thoughts about it are "let's just close it, adding ::Bool is easy, and the only problem with it is that one can forget to do it; but one can also forget to use @gapproperty instead of @gapattribute, so we really gain nothing but have to invest a lot of work."
But since you already invested the work now, I am reluctant to let it go to waste... OTOH if we add it, we need to maintain it, and it ever so slightly increases complexity...
Perhaps @ThomasBreuer has a thought on this as well?
|
|
||
| Return `true` if the input integer is odd. | ||
| """ | ||
| @gapproperty isoddint_GAP(x::Int) = GAP.Globals.IsOddInt(x) |
There was a problem hiding this comment.
Perhaps there could be a test using @inferred to verify it really is type stable and returning a Bool?
Yeah, I totally understand and am for than fine with just closing this PR. If I remember correctly, I was a bit frustrated from some other task and just wanted something "easy to tackle" and thus just took something from the issue tracker to do. Next time, I'll talk to you beforehand :) |
|
Just to avoid misunderstanding: of course it is fine for you to work on something w/o consulting with me first, I just want to avoid causing frustration on your part when I then later come and say "oh no we don't want that" and discard your hard work -- I hate doing that :-/. Hence my request (I think you already got that, but internet communication is difficult). And I totally get the bit about working on something "attainable" when frustrated on something else, I also do that ;-) |
|
We talked about it, and decided to not move forward. Thank again Lars for your efforts, and sorry! |
Resolves #680.