-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install Nemo and cache it #99
Conversation
Codecov Report
@@ Coverage Diff @@
## master #99 +/- ##
==========================================
- Coverage 51.38% 50.66% -0.72%
==========================================
Files 33 37 +4
Lines 1919 2481 +562
==========================================
+ Hits 986 1257 +271
- Misses 933 1224 +291
|
To my surprise, installing Nemo.jl only adds ~10 minutes to the Travis build. |
c3cc829
to
8f552de
Compare
224173c
to
33bcbf3
Compare
This seems to be working fine now. There is the question of what happens if the Julia code in Nemo "should be" recompiled due to a change in the Julia nightly... not sure whether Julia does that automatically (probably not?), or else how to trigger it manually... I think (but might be wrong) that the part taking up most of the time is compiling all the C libraries, so as long as we can avoid that, it should still be useful. Perhaps @wbhart or some other Julia experts have some insights on that? |
I believe Julia will recompile if its binary changes. However, it won't recompile Flint and so on, I think, as this shouldn't be needed. You are right that the first build takes a while, due to building all the C libraries. We surely want to eventually move over to using binaries to speed that up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assumning Bills comment, this is fine for now.
You can merge it if you want to.
No description provided.