Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Nemo and cache it #99

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Conversation

fingolfin
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 29, 2018

Codecov Report

Merging #99 into master will decrease coverage by 0.71%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
- Coverage   51.38%   50.66%   -0.72%     
==========================================
  Files          33       37       +4     
  Lines        1919     2481     +562     
==========================================
+ Hits          986     1257     +271     
- Misses        933     1224     +291
Impacted Files Coverage Δ
JuliaExperimental/gap/gapnemo.g 97.91% <0%> (ø)
JuliaExperimental/gap/realcyc.g 85.18% <0%> (ø)
JuliaExperimental/gap/numfield.g 30.99% <0%> (ø)
JuliaExperimental/gap/hnf.g 42.85% <0%> (ø)
JuliaExperimental/gap/arith.gi 77.04% <0%> (+1.63%) ⬆️
JuliaExperimental/read.g 96.77% <0%> (+15.29%) ⬆️
JuliaExperimental/julia/realcyc.jl 86.66% <0%> (+86.66%) ⬆️
JuliaExperimental/julia/hnf.jl 100% <0%> (+100%) ⬆️

@fingolfin
Copy link
Member Author

To my surprise, installing Nemo.jl only adds ~10 minutes to the Travis build.

@fingolfin fingolfin changed the title Install Nemo and cache it (WIP) Install Nemo and cache it Oct 30, 2018
@fingolfin fingolfin requested a review from sebasguts October 30, 2018 08:52
@fingolfin
Copy link
Member Author

This seems to be working fine now. There is the question of what happens if the Julia code in Nemo "should be" recompiled due to a change in the Julia nightly... not sure whether Julia does that automatically (probably not?), or else how to trigger it manually... I think (but might be wrong) that the part taking up most of the time is compiling all the C libraries, so as long as we can avoid that, it should still be useful. Perhaps @wbhart or some other Julia experts have some insights on that?

@fingolfin fingolfin requested a review from wbhart October 30, 2018 08:55
@wbhart
Copy link
Contributor

wbhart commented Oct 30, 2018

I believe Julia will recompile if its binary changes. However, it won't recompile Flint and so on, I think, as this shouldn't be needed. You are right that the first build takes a while, due to building all the C libraries. We surely want to eventually move over to using binaries to speed that up.

Copy link
Contributor

@sebasguts sebasguts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assumning Bills comment, this is fine for now.

You can merge it if you want to.

@fingolfin fingolfin merged commit 2b10832 into oscar-system:master Oct 30, 2018
@fingolfin fingolfin deleted the mh/test-nemo branch October 30, 2018 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants