[ToricVarieties] Catch more edge cases

oscar-system · Oct 27, 2023 · 103262f · 103262f
1 parent a0262ff
commit 103262f
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/src/AlgebraicGeometry/ToricVarieties/NormalToricVarieties/standard_constructions.jl b/src/AlgebraicGeometry/ToricVarieties/NormalToricVarieties/standard_constructions.jl
@@ -10,6 +10,7 @@ Normal toric variety
 ```
 """
 function affine_space(::Type{NormalToricVariety}, d::Int)
+  @req d >= 0 "Dimension must be non-negative"
   C = positive_hull(identity_matrix(ZZ, d))
   variety = normal_toric_variety(C)
   return variety
@@ -28,6 +29,7 @@ Normal toric variety
 ```
 """
 function projective_space(::Type{NormalToricVariety}, d::Int)
+  @req d >= 0 "Dimension must be non-negative"
   f = normal_fan(Oscar.simplex(d))
   pm_object = Polymake.fulton.NormalToricVariety(Oscar.pm_object(f))
   variety = NormalToricVariety(pm_object)
@@ -51,6 +53,7 @@ Normal toric variety
 ```
 """
 function weighted_projective_space(::Type{NormalToricVariety}, w::Vector{T}) where {T <: IntegerUnion}
+  @req length(w) > 0 "At least one weight must be specified"
   if all(a -> isone(a), w)
     return projective_space(NormalToricVariety, length(w)-1)
   end