Add missing ring interface function for AlgClosure (#3113)

oscar-system · Dec 15, 2023 · 694f594 · 694f594
1 parent 4bbbef4
commit 694f594
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/Rings/AlgClosureFp.jl b/src/Rings/AlgClosureFp.jl
@@ -44,6 +44,8 @@ end
 elem_type(::Type{AlgClosure{T}}) where T = AlgClosureElem{T}
 parent_type(::Type{AlgClosureElem{T}}) where T = AlgClosure{T}
 
+Oscar.canonical_unit(a::AlgClosureElem) = is_zero(a) ? one(a) : a
+
 function show(io::IO, a::AlgClosureElem)
   print(io, data(a))
 end
@@ -325,6 +327,7 @@ function has_preimage(mp::MapFromFunc{T, AlgClosure{S}}, elm::AlgClosureElem{S})
   return true, preimage(mp, elm)
 end
 
+
 end # AlgClosureFp
 
 import .AlgClosureFp:

diff --git a/test/Rings/AlgClosureFp.jl b/test/Rings/AlgClosureFp.jl
@@ -177,4 +177,8 @@ end
     a = K(gen(F1))
     @test K(L(a)) == a
   end
+
+  R = algebraic_closure(GF(3,1))
+  Kt, t = rational_function_field(R, "t")
+  @test sprint(show, t) isa String
 end