fix: is_irreducible for number field order elements

oscar-system · Jan 7, 2025 · 9e6a6b4 · 9e6a6b4
1 parent 264490b
commit 9e6a6b4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/NumberTheory/NmbThy.jl b/src/NumberTheory/NmbThy.jl
@@ -180,9 +180,9 @@ function is_irreducible(a::AbsSimpleNumFieldOrderElem)
     return false
   end
   s, ms = Hecke.sunit_mod_units_group_fac_elem(S)
-  V = transpose(matrix(ZZ, [ZZRingElem[valuation(ms(x), y) for y = S] for x = gens(s)]))
-  b = transpose(matrix(ZZ, [ZZRingElem[valuation(a, y) for y = S]]))
-  sol = solve(V, b)
+  V = matrix(ZZ, [ZZRingElem[valuation(ms(x), y) for y = S] for x = gens(s)])
+  b = matrix(ZZ, [ZZRingElem[valuation(a, y) for y = S]])
+  sol = transpose(solve(V, b))
 
   #want to write sol = x+y where
   # Cx, Cy > 0

diff --git a/test/NumberTheory/nmbthy.jl b/test/NumberTheory/nmbthy.jl
@@ -11,6 +11,7 @@ end
   f = factorizations(zk(6))
   @test length(f) == 2
   @test all(x -> evalu(x) == 6, f)
+  @test !is_irreducible(zk(6))
 end
 
 @testset "norm_equation.absolute" begin