-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structure in experimental #2146
Comments
Yeah so the directory tree would look like this:
Of course there could be more files in each of the subdirs. The content of import Glob # just to keep this short, obviously we can also do it "by hand"
for fname in Glob.glob("*/src/main.jl")
include(fname)
end or if that's too "automagic", of course also this is fine: include("ExteriorAlgebra/src/main.jl")
include("GaloisGrp/src/main.jl") Similar for My main concern is whether and how this will work with the documentation, so that's the first thing I'd try experimentally: change |
And then next, how to add those files into the manual... right now we hook some of them into various parts of the hierarchy, manually. We can of course continue this, it's fine. Though I note that there are a few "orphaned" files in |
For the manual I wanted to go with your proposal from #2011 and introduce an |
I already talked about this to @fingolfin and @HereAround . The folder structure for experimental stuff is a bit confusing. There is
experimental
for source code, separate fromsrc
, whiletest/Experimental
contains the tests anddocs/src/Experimental
contains the docs. Max proposed the following structure, which I like very much (if it is possible):Then one could still have
experimental/test.jl
andexperimental/experimental.jl
for the code inclusions, not sure about the docs. In case there is not too much discussion, I would go ahead and implement these things in the lie algebra PRs #2145 and #2115, of course while coordinating with the respective authors. I don't think it is necessary to change this for the remaining things, but I'd also adapt the developer docs and then the old style should slowly fade out.Maybe this also makes things easier for #2011.
The text was updated successfully, but these errors were encountered: