Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static testing and test/Project.toml for *all* packages #2385

Closed
16 tasks done
lgoettgens opened this issue May 12, 2023 · 1 comment
Closed
16 tasks done

Static testing and test/Project.toml for *all* packages #2385

lgoettgens opened this issue May 12, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@lgoettgens
Copy link
Member

lgoettgens commented May 12, 2023

This is a checklist to implement the changes proposed in #1964 and #2374 for Oscar.jl to be done similarly in the other packages.

Move test dependencies from Project.toml's [extra] to test/Project.toml (#2374)

Add Aqua.jl for some static testing (#1964/#2370)

fix stale_deps check by Aqua.jl once JuliaTesting/Aqua.jl#113 is available

@lgoettgens lgoettgens added the enhancement New feature or request label May 12, 2023
@lgoettgens lgoettgens changed the title Static testing abd test/Project.toml for *all* packages Static testing and test/Project.toml for *all* packages May 12, 2023
@fingolfin
Copy link
Member

Just as a heads-up, the "weird error with GAP_lib_jll" in the stale_deps check by Aqua.jl is caused by the GAP package Browse printing a \r character upon initialization (see also gap-system/gap#430 ; ping @ThomasBreuer). Unfortunately I currently know no way to avoid that. So instead I submitted JuliaTesting/Aqua.jl#113 to make Aqua more robust.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants