Add Aqua.jl for some static testing
#883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #883 +/- ##
=======================================
Coverage 75.65% 75.65%
=======================================
Files 51 51
Lines 4115 4115
=======================================
Hits 3113 3113
Misses 1002 1002 |
fingolfin
reviewed
May 23, 2023
| stale_deps=false, # some weird error with GAP_lib_jll | ||
| deps_compat=true, | ||
| project_toml_formatting=true, | ||
| piracy=false # TODO: fix |
There was a problem hiding this comment.
Note that I believe the reported issues are not actuality type piracy but rather a bug in Aqua; I already reported this there, too
There was a problem hiding this comment.
I haven't looked into everything that has been reported by Aqua and just disabled the failing checks for the time being. This should be tackled in future PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See oscar-system/Oscar.jl#2385.