Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import code from the project basisLieHighestWeight #2115

Closed
wants to merge 25 commits into from
Closed
Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
e811583
first commit of basisLieHighestWeight
BenWilop Mar 24, 2023
365d04a
basisLieHighestWeight tests
BenWilop Mar 24, 2023
b413207
deleted german comments, adapted tests, removed LongestWord
BenWilop Mar 24, 2023
5e67d55
[LieAlgebraBases] Base file for docs
lkastner Mar 24, 2023
c6219e8
[LieAlgebraBases] Eliminate abbreviation forGap
lkastner Mar 24, 2023
8cd22e9
[LieAlgebraBases] Eliminate abbreviation G = GAP.Globals
lkastner Mar 24, 2023
6b081e3
Typo prevented tests from running
lkastner Mar 24, 2023
0089ae0
[BasisLieHighestWeight] First docs example
lkastner Mar 24, 2023
3c5545c
partial fix for SparseArrays
BenWilop Mar 24, 2023
1ec8173
substituted Package SparseArray with Oscar SMat
BenWilop Mar 24, 2023
e581b4b
substituted Package SparseArray with Oscar SMat
BenWilop Mar 24, 2023
34e575a
Merge branch 'bwilop/basisLieHighestWeight' of github.com:oscar-syste…
lkastner Mar 27, 2023
0051076
Merge branch 'bwilop/basisLieHighestWeight' of github.com:oscar-syste…
lkastner Mar 27, 2023
752f615
switched monomials to Oscar type
BenWilop Apr 8, 2023
828f46c
Merge branch 'bwilop/basisLieHighestWeight' of github.com:oscar-syste…
BenWilop Apr 8, 2023
1fb11d1
Merge remote-tracking branch 'origin/master' into bwilop/basisLieHigh…
lkastner Apr 8, 2023
0a30aab
[BasisLieHighestWeight] Adjusted to new structure
lkastner Apr 3, 2023
fcc38fb
[BasisLieHighestWeight] Forgotten removal of 'using Distributed'?
lkastner Apr 9, 2023
14f5cc4
[BasisLieHighestWeight] Remove TestSetExtension
lkastner Apr 9, 2023
3ae434f
more explanatory variable names and type declaration for functions
BenWilop Apr 10, 2023
b650769
a few small changes to improve readibility
BenWilop Apr 10, 2023
16e7897
few more small changes to types / names and typos
BenWilop Apr 12, 2023
49b6ddc
pseudocode for basis_lie_highest_weight
BenWilop Apr 12, 2023
02918d3
changed RootCOnversion type A to make it consistent with the other fu…
BenWilop Apr 15, 2023
20ab80e
removed Markdown
BenWilop Apr 23, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ version = "0.12.0-DEV"
[deps]
AbstractAlgebra = "c3fe647b-3220-5bb0-a1ea-a7954cac585d"
AlgebraicSolving = "66b61cbe-0446-4d5d-9090-1ff510639f9d"
Distributed = "8ba89e20-285c-5b6f-9357-94700520ee1b"
lkastner marked this conversation as resolved.
Show resolved Hide resolved
DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae"
GAP = "c863536a-3901-11e9-33e7-d5cd0df7b904"
Hecke = "3e1990a7-5d81-5526-99ce-9ba3ff248f21"
Expand All @@ -19,6 +20,7 @@ Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
RandomExtensions = "fb686558-2515-59ef-acaa-46db3789a887"
RecipesBase = "3cdcf5f2-1ef4-517c-9805-6587b60abb01"
Singular = "bcd08a7b-43d2-5ff7-b6d4-c458787f915c"
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am somewhat reluctant to add a depdency on SparseArrays as we have our own sparse matrix type. But I guess it depends on what you use it for, which is not clear to me.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changed now and the code uses only the Oscar-Type now. But there are operations that are not supported in Oscar, such as SparseMatrix*SparseMatrix and the Kronecker-Product.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused; what does "This changed now" mean? SparseArrays still is listed here (as is Distributed)

TOPCOM_jll = "36f60fef-b880-50dc-9289-4aaecee93cc3"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
UUIDs = "cf7118a7-6976-5b1a-9a39-7adc72f591a4"
Expand Down
1 change: 1 addition & 0 deletions docs/doc.main
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@
],
"Miscellaneous" => [
"AlgebraicGeometry/Miscellaneous/miscellaneous.md",
"Experimental/basisLieHighestWeight.md",
]
],

Expand Down
16 changes: 16 additions & 0 deletions docs/src/Experimental/basisLieHighestWeight.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
```@meta
CurrentModule = Oscar.BasisLieHighestWeight
```

```@setup oscar
using Oscar.BasisLieHighestWeight
```

```@contents
Pages = ["basisLieHighestWeight.md"]
```

# Monomial bases for Lie algebras
```@docs
basisLieHighestWeight2
```
1 change: 1 addition & 0 deletions experimental/Experimental.jl
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,4 @@ include("Schemes/BlowupMorphism.jl")
include("Schemes/ToricSchemes/include.jl")

include("ExteriorAlgebra/ExteriorAlgebra.jl")
include("basisLieHighestWeight/main.jl")
Loading