Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving various issues #2229

Merged
merged 3 commits into from
Apr 7, 2023
Merged

Resolving various issues #2229

merged 3 commits into from
Apr 7, 2023

Conversation

wdecker
Copy link
Collaborator

@wdecker wdecker commented Apr 6, 2023

adding to PR #2225

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #2229 (8f29e64) into master (d69ae53) will increase coverage by 0.04%.
The diff coverage is 87.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2229      +/-   ##
==========================================
+ Coverage   73.37%   73.42%   +0.04%     
==========================================
  Files         367      367              
  Lines       49937    49945       +8     
==========================================
+ Hits        36643    36672      +29     
+ Misses      13294    13273      -21     
Impacted Files Coverage Δ
src/Rings/mpoly-ideals.jl 90.94% <50.00%> (-0.30%) ⬇️
src/Rings/MPolyQuo.jl 85.28% <100.00%> (+4.36%) ⬆️

... and 4 files with indirect coverage changes

@wdecker
Copy link
Collaborator Author

wdecker commented Apr 6, 2023

I do not understand why the docu test works fine, but some other tests show diffs in the documentation.

@fingolfin
Copy link
Member

fingolfin commented Apr 7, 2023

The docu tests were changed to only build the documentation, not test it.

@fingolfin fingolfin merged commit 7531617 into master Apr 7, 2023
@fingolfin fingolfin deleted the Wolfram branch April 7, 2023 11:44
@wdecker
Copy link
Collaborator Author

wdecker commented Apr 7, 2023

Why? That means if I have mistakes I have to wait, say, 130 minutes before I see them, otherwise it would be 30 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants