Misc refactorings #2359
Misc refactorings #2359
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2359 +/- ##
=======================================
Coverage 71.62% 71.63%
=======================================
Files 377 378 +1
Lines 52484 52496 +12
=======================================
+ Hits 37593 37603 +10
- Misses 14891 14893 +2
|
|
|
||
| include("Groups/Groups.jl") | ||
|
|
||
| include("Rings/Rings.jl") |
There was a problem hiding this comment.
Could we include this before Groups.jl, and then move this:
include("Groups/group_characters.jl") # needs some Rings functionality
include("Groups/action.jl") # needs some PolynomialRings functionality
also into Groups/Groups.jl?
Or is there a dependency in the Rings.jl code on code in Groups.jl that prevents it (if so, perhaps a comment could be added explaining that)
| # In a bare repo HEAD will not point to the correct commit so we use the git | ||
| # tree-hash that Pkg.jl provides and manually map this to a corresponding | ||
| # commit. | ||
| function _lookup_commit_from_cache(url::AbstractString, tree::AbstractString) |
There was a problem hiding this comment.
I think also the const globals jll_deps and cornerstones should be moved to utils.jl.
(And perhaps it would make sense to split this into three files, say utils/versioninfo.jl, utils/docs.jl, utils/tests.jl or so -- but I am fine either way, just an idea)
There was a problem hiding this comment.
Another possible addition to the hypothetical utils dir might be utils/rand.jl with the get_seeded_rng function and friends, also from Oscar.jl.
| @@ -70,94 +70,7 @@ end | |||
| # force trigger recompile when folder changes | |||
| include_dependency("../experimental") | |||
There was a problem hiding this comment.
How about moving the code from line 31 to here, which deals with experimental, over to ../experimental/Experimental.jl?
|
Hmm, seems I was too late. Ah well. |
|
Also const aadir = Base.pkgdir(AbstractAlgebra)
const nemodir = Base.pkgdir(Nemo)
const heckedir = Base.pkgdir(Hecke)should go to |
Oscar.jlinto subfolders into a more package like structure whenever possible-testfrom filenames, since these are already in the test folderOscar.jlintosrc/utils.jl(docs, versioninfo)