Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor improvements #2609

Merged
merged 2 commits into from
Aug 2, 2023
Merged

minor improvements #2609

merged 2 commits into from
Aug 2, 2023

Conversation

ThomasBreuer
Copy link
Member

  • renamed representative_action to is_conjugate_with_data, as suggested by @fieker (but keep representative_action as an alias),
  • support the syntax tbl % p for constructing p-modular character tables, as suggested by @fieker,
  • added some tests for describe(projective_general_linear_group(n, q)) and describe(projective_special_linear_group(n, q)),
  • mention more differences between Julia and GAP

@ThomasBreuer
Copy link
Member Author

"5 failing, 6 successful, and 1 cancelled checks":
The 5 failing checks end with "The operation was canceled."
The other one (Run tests / test (nightly, macOS-latest) was "Cancelled after 150m".

@thofma
Copy link
Collaborator

thofma commented Jul 31, 2023

Should all be #2441.

@ThomasBreuer
Copy link
Member Author

ThomasBreuer commented Aug 1, 2023

I have restarted the failed tests, the required test with Julia 1.6 is now expected to succeed (see the discussion of #2441) ...

No, it was again cancelled.

- renamed `representative_action` to `is_conjugate_with_data`
  (but keep `representative_action` as an alias)
- support the syntax `tbl % p` for constructing `p`-modular character tables
- added some tests for `describe(projective_general_linear_group(n, q))`
  and `describe(projective_special_linear_group(n, q))`
- mention more differences between Julia and GAP
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #2609 (a109fac) into master (995942d) will decrease coverage by 0.03%.
Report is 2 commits behind head on master.
The diff coverage is 73.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2609      +/-   ##
==========================================
- Coverage   72.13%   72.11%   -0.03%     
==========================================
  Files         429      429              
  Lines       60531    60532       +1     
==========================================
- Hits        43667    43651      -16     
- Misses      16864    16881      +17     
Files Changed Coverage Δ
src/Groups/matrices/MatGrp.jl 94.05% <57.14%> (ø)
src/Groups/GAPGroups.jl 82.80% <60.00%> (ø)
experimental/QuadFormAndIsom/src/embeddings.jl 96.10% <100.00%> (ø)
.../QuadFormAndIsom/src/hermitian_miranda_morrison.jl 72.49% <100.00%> (ø)
src/Groups/GrpAb.jl 90.82% <100.00%> (ø)
src/Groups/group_characters.jl 88.23% <100.00%> (+0.01%) ⬆️
src/Groups/gsets.jl 91.00% <100.00%> (ø)
src/Groups/matrices/linear_isconjugate.jl 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

@ThomasBreuer
Copy link
Member Author

The required test test (1.6, ubuntu-latest) (pull_request) found an error at test/AlgebraicGeometry/Schemes/duValSing.jl:16, which is not likely to be related to the changes from this pull request.

Restarted this test.

@thofma
Copy link
Collaborator

thofma commented Aug 2, 2023

Probably #2531

@ThomasBreuer
Copy link
Member Author

@thofma Yes, probably.
(The same happened with other pull requests, for example #2410 and #2528, and also in oscar-system/GAP.jl/pull/925; running the failed test again usually helps.)

@ThomasBreuer ThomasBreuer merged commit 0621c9a into oscar-system:master Aug 2, 2023
@ThomasBreuer ThomasBreuer deleted the TB_misc branch August 2, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants