LieAlgebras: Restrict to work over fields only #2901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2901 +/- ##
=======================================
Coverage 80.39% 80.40%
=======================================
Files 456 456
Lines 65235 65227 -8
=======================================
Hits 52447 52447
+ Misses 12788 12780 -8
|
ThomasBreuer
approved these changes
Oct 10, 2023
Yes, as I e.g. do not wanna have a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some functions already defined, I have doubts about the correctness over general rings, in particular in the existence of zero divisors.
So, I would like to restrict everything to work only over fields for now. If someone (maybe @fingolfin ?) with the required knowledge wants to work with Lie rings in the future, after a per-case decision one can widen the signatures again.