Add docs and tests for CartanMatrix.jl #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
reviewed
Nov 10, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2982 +/- ##
==========================================
+ Coverage 80.09% 80.19% +0.09%
==========================================
Files 491 492 +1
Lines 69349 69529 +180
==========================================
+ Hits 55547 55756 +209
+ Misses 13802 13773 -29
|
lgoettgens
reviewed
Nov 13, 2023
| then this will be expressed by $m_{ij} = 0$ (instead of the usual convention $m_{ij} = \infty$). | ||
| The keyword argument `check` can be set to `false` to skip verification whether `gcm` is indeed a generalized Cartan matrix. | ||
| """ | ||
| function coxeter_from_cartan_matrix(gcm; check::Bool=true) |
There was a problem hiding this comment.
Naming discussion and review postponed until this file gets tidied up (in a future PR).
Co-authored-by: Lars Göttgens <[email protected]>
Co-authored-by: Lars Göttgens <[email protected]>
Co-authored-by: Lars Göttgens <[email protected]>
felix-roehrich
force-pushed
the
fr/cartan-docs-tests
branch
from
f48f741 to
dae4db7
Compare
lgoettgens
approved these changes
Nov 17, 2023
|
Can we get this merged? Maybe @thofma or @fingolfin could do that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of #2689 and adds docs and tests for the CartanMatrix.jl file added in this PR. It also adds four new functions, name
cartan_symmterizer,cartan_bilinear_form,cartan_typeandcartan_type_with_ordering.Work isn't completely finished, but I want to open the discussion for the naming of functions.
For one @lgoettgens suggested to rename
cartan_to_coxeter_matrixto something likecoxeter_from_cartan_matrix(to follow the convention of dst_src if I remember correctly).If time permits I will add a function for Cartan matrices of affine type. My suggestion would be
cartan_matrix(fam::Symbol, rk::Int, aff::Int). I do not plan on handling the hyperbolic case, What is you opinion @fingolfin ?