Renaming of revlex, negrevlex, introduction of deginvlex #3038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
reviewed
Nov 23, 2023
lgoettgens
reviewed
Nov 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3038 +/- ##
=======================================
Coverage 80.31% 80.32%
=======================================
Files 492 492
Lines 69528 69553 +25
=======================================
+ Hits 55844 55867 +23
- Misses 13684 13686 +2
|
hannes14
reviewed
Nov 27, 2023
hannes14
reviewed
Nov 27, 2023
| @deprecate revlex(R::MPolyRing) invlex(R::MPolyRing) | ||
| @deprecate revlex(v::AbstractVector{<:MPolyRingElem}) invlex(v::AbstractVector{<:MPolyRingElem}) | ||
| @deprecate negrevlex(R::MPolyRing) ngeinvlex(R::MPolyRing) | ||
| @deprecate negrevlex(v::AbstractVector{<:MPolyRingElem}) neginvlex(v::AbstractVector{<:MPolyRingElem}) |
There was a problem hiding this comment.
why deprecate revlex/negrevlex: it is not exported?
There was a problem hiding this comment.
they are exported on the current master. @deprecate exports them itself, if the second argument is exported as well (so invlex/neginvlex here)
Co-authored-by: Max Horn <[email protected]>
Co-authored-by: Max Horn <[email protected]>
Co-authored-by: Max Horn <[email protected]>
Co-authored-by: Max Horn <[email protected]>
Co-authored-by: Max Horn <[email protected]>
Co-authored-by: Max Horn <[email protected]>
Co-authored-by: Max Horn <[email protected]>
Co-authored-by: Max Horn <[email protected]>
Co-authored-by: Max Horn <[email protected]>
Co-authored-by: Max Horn <[email protected]>
Co-authored-by: Max Horn <[email protected]>
Co-authored-by: Max Horn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was initiated by #2950.
Singular.jlto version0.20.0.