More functionality for Weyl groups #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
felix-roehrich
commented
Nov 27, 2023
•
felix-roehrich
commented
- make WeylGroups iterable
- add WeylOrbit functionality
- add more tests
- fix bugs in CartanMatrix.jl and RootSystem.jl
lgoettgens
force-pushed
the
fr/weyl-groups
branch
from
dd578c8 to
5a7933e
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3051 +/- ##
==========================================
+ Coverage 80.49% 80.57% +0.07%
==========================================
Files 520 522 +2
Lines 70069 70422 +353
==========================================
+ Hits 56403 56743 +340
- Misses 13666 13679 +13
|
felix-roehrich
force-pushed
the
fr/weyl-groups
branch
from
6aa1203 to
c2fbfd1
Compare
felix-roehrich
force-pushed
the
fr/weyl-groups
branch
from
55dad24 to
5d51cc2
Compare
felix-roehrich
force-pushed
the
fr/weyl-groups
branch
from
5d51cc2 to
44e6532
Compare
felix-roehrich
changed the title
lgoettgens
approved these changes
Jan 24, 2024
Co-authored-by: Lars Göttgens <[email protected]>
Co-authored-by: Lars Göttgens <[email protected]>
|
Can we get a quick merge of this (once CI finishes)? This PR does some GroupsCore shenanigans, which I would like to tackle in #3231. |
|
Ping @thofma |
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Jan 26, 2024
ooinaruhugh
pushed a commit
to ooinaruhugh/Oscar.jl
that referenced
this pull request
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.