Start revising printing of modules #3199
Conversation
fingolfin
requested review from
ederc,
jankoboehm,
wdecker and
HechtiDerLachs
docs/src/CommutativeAlgebra/ModulesOverMultivariateRings/complexes.md
Outdated
Show resolved
Hide resolved
docs/src/CommutativeAlgebra/ModulesOverMultivariateRings/complexes.md
Outdated
Show resolved
Hide resolved
| by Submodule with 1 generator | ||
| 1 -> x^4*e[1] | ||
| to subquotient of Submodule with 1 generator | ||
| 1 -> e[1] |
There was a problem hiding this comment.
Maybe this should use Indent() ?
| 1 -> e[1] | |
| 1 -> e[1] |
There was a problem hiding this comment.
Can't do that right now because it runs into a bug in pretty printing, see Nemocas/AbstractAlgebra.jl#1561
src/Modules/ModulesGraded.jl
Outdated
| Graded free module R^3([0]) of rank 3 over R | ||
| Graded free module Graded multivariate polynomial ring^3([0]) of rank 3 over graded multivariate polynomial ring |
There was a problem hiding this comment.
I think this will be objected to by @jankoboehm and @wdecker and should be fixed. Probably it has to do with switches from compact to supercompact somewhere? Probably only the old method's signature (of the one which was looking up the rings to fish out their names) has to be adjusted.
There was a problem hiding this comment.
Yes I explained this elsewhere. The origin of the issues is that @show_name macro from AA only checks for compact; this is its code:
macro show_name(io, O)
return :( begin
local i = $(esc(io))
local o = $(esc(O))
s = get_attribute(o, :name)
if s === nothing
sy = find_name(o)
if sy === nothing
sy = extra_name(o)
end
if sy !== nothing
s = string(sy)
set_name!(o, s)
end
end
if get(i, :compact, false) && s !== nothing
if AbstractAlgebra.PrettyPrinting._supports_io_custom(i)
print(i, LowercaseOff())
end
print(i, s)
return
end
end )
end
One option would be to set both compact and supercompact.
@thofma @fieker should @show_name be changed to also check supercompact? (or perhaps even instead of compact?)
There was a problem hiding this comment.
For now I made it set both compact and supercompact, but this will be the last change I'll make to this PR, from here on the algebraic geometry group should take over, as outlined in the description of this PR.
| @@ -49,23 +49,23 @@ julia> U = complement_of_prime_ideal(P); | |||
| julia> RL, _ = localization(R, U); | |||
|
|
|||
| julia> FRL = free_module(RL, 2, "f") | |||
| Free module of rank 2 over Localization of multivariate polynomial ring in 3 variables over QQ at complement of prime ideal(x, y, z) | |||
| Free module of rank 2 over localized ring | |||
There was a problem hiding this comment.
maybe localized polynomial ring would be better, given that we also spell out multivariate polynomial ring? But I have no strong opinion on that .
There was a problem hiding this comment.
Maybe, but that's beyond the scope of this PR, the show method for AbsLocalizedRing would have to be adjusted.
| Map with following data | ||
| Domain: | ||
| ======= | ||
| Free module of rank 3 over Multivariate polynomial ring in 3 variables over QQ | ||
| Codomain: | ||
| ========= | ||
| Free module of rank 2 over Multivariate polynomial ring in 3 variables over QQ | ||
| Module homomorphism | ||
| from free module of rank 3 over multivariate polynomial ring | ||
| to free module of rank 2 over multivariate polynomial ring |
There was a problem hiding this comment.
This looks much better now in my opinion.
|
Thanks a lot for making it available, will make a suggestion based on it, and then we can discuss whether it does the job. |
fingolfin
force-pushed
the
mh/show-UngradedModules
branch
3 times, most recently
from
c125e9b to
b01cdde
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3199 +/- ##
==========================================
- Coverage 81.65% 81.64% -0.02%
==========================================
Files 546 546
Lines 73102 73099 -3
==========================================
- Hits 59692 59682 -10
- Misses 13410 13417 +7
|
fingolfin
force-pushed
the
mh/show-UngradedModules
branch
from
b01cdde to
5ddece9
Compare
|
This has a ton of conflicts now, and has been basically ignored for months, so it seems it is best if someone else starts from scratch with this. |
First steps towards resolving #2891 which is important for the book.
The code changes are all in the first commit, the second commit just contains the changed produced by:
I started this back in October, and just rebased it (as promised on Wednesday, sorry for the delay), and regenerated the docs.
This is definitely not the final version, it has clear issues, but at least it is start. So, what to do with this, some options:
Any is fine by me, it's not as if there is much in it.