Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove some (broken) leftover from surface serialization #3545

Merged
merged 1 commit into from
Mar 30, 2024

Conversation

thofma
Copy link
Collaborator

@thofma thofma commented Mar 27, 2024

I guess we forgot to remove those after adding the proper database. Fixes the following bug:

julia> using Oscar
OSCAR 1.1.0-DEV  https://docs.oscar-system.org  Type "?Oscar" for help

julia> Oscar.R
Multivariate polynomial ring in 5 variables over GF(31991) graded by

[23792] signal (11.2): Segmentation fault: 11
in expression starting at none:0
fmpz_mat_entry at /bla/artifacts/f9bd64315b199a85cd681d69242b3cf75db9f49b/lib/libflint.dylib (unknown line)
jlplt_fmpz_mat_entry_9288 at /bla/compiled/v1.10/Hecke/lhBAK_0vvt3.dylib (unknown line)
Allocations: 18798613 (Pool: 18756078; Big: 42535); GC: 13
[1]    23792 segmentation fault  julia 

(The variable R was precompiled, but this is cannot work.)

@thofma thofma requested a review from fieker March 27, 2024 12:18
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Merging #3545 (f205e1a) into master (d367722) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3545      +/-   ##
==========================================
- Coverage   82.16%   82.16%   -0.01%     
==========================================
  Files         568      568              
  Lines       77055    77055              
==========================================
- Hits        63312    63311       -1     
- Misses      13743    13744       +1     
Files Coverage Δ
src/AlgebraicGeometry/Surfaces/SurfacesP4.jl 14.81% <ø> (ø)

... and 1 file with indirect coverage changes

@thofma thofma merged commit 8667f84 into master Mar 30, 2024
30 of 31 checks passed
@thofma thofma deleted the th/byebyeR branch March 30, 2024 19:48
@lgoettgens lgoettgens added the backport 1.0.x Should be backported to the release 1.0 branch label Mar 30, 2024
benlorenz pushed a commit that referenced this pull request Apr 9, 2024
@benlorenz benlorenz mentioned this pull request Apr 9, 2024
@benlorenz benlorenz removed the backport 1.0.x Should be backported to the release 1.0 branch label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants