Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add resultant for list of multivariate polynomials #3546

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

thofma
Copy link
Collaborator

@thofma thofma commented Mar 27, 2024

I need it for an application and I think it would be nice to have. There are more algorithms that one could implement, but this one works fine for my application.

@wdecker maybe you could have a look?

Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Merging #3546 (9d71e8c) into master (d367722) will increase coverage by 0.03%.
Report is 25 commits behind head on master.
The diff coverage is 97.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3546      +/-   ##
==========================================
+ Coverage   82.16%   82.20%   +0.03%     
==========================================
  Files         568      569       +1     
  Lines       77055    77291     +236     
==========================================
+ Hits        63312    63534     +222     
- Misses      13743    13757      +14     
Files Coverage Δ
src/Rings/resultant.jl 97.56% <97.56%> (ø)

... and 41 files with indirect coverage changes

@thofma thofma force-pushed the th/res branch 2 times, most recently from 0558b5b to ed12ca6 Compare March 28, 2024 08:21
@fieker
Copy link
Contributor

fieker commented Apr 3, 2024

Can someone checke the math? The wiki page wants homogenous polynomials, but this is not checked (by the looks: deliberatey not)
Should this apply to graded polynomials (only)? Standart grading? Any grading?

@thofma
Copy link
Collaborator Author

thofma commented Apr 3, 2024

It must be homogeneous with respect to the standard grading. It is not checked, because it cannot be checked with the current state of OSCAR:

julia> K = algebraic_closure(QQ); Kxy, (x, y) = K["x", "y"]; is_homogeneous(x)
true

julia> K = QQ; Kxy, (x, y) = K["x", "y"]; is_homogeneous(x)
ERROR: MethodError: no method matching is_homogeneous(::QQMPolyRingElem)

@fingolfin
Copy link
Member

Nemocas/AbstractAlgebra.jl#1649 adds is_homogeneous for all MPolyRingElem

@thofma
Copy link
Collaborator Author

thofma commented Apr 4, 2024

I remembered that we have an _is_homogeneous for this purpose. I am using this and added the test. This should be good to go now.

@lgoettgens lgoettgens requested a review from wdecker April 4, 2024 09:21
@thofma thofma merged commit 178f656 into master Apr 4, 2024
28 checks passed
@thofma thofma deleted the th/res branch April 4, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants