-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests of book chapter to CI. #3588
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keep repl per chapter simplify rng usage use broken and skipped lists more regex
This reverts commit d641147.
benlorenz
reviewed
Apr 11, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3588 +/- ##
==========================================
+ Coverage 81.72% 82.17% +0.44%
==========================================
Files 573 573
Lines 77503 77618 +115
==========================================
+ Hits 63343 63780 +437
+ Misses 14160 13838 -322
|
Pretty cool! |
fingolfin
approved these changes
Apr 12, 2024
I added a backport label, but this needs some manual work to undo some changes in the output for master / reimport of the original jlcon files. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds most of the book chapters to the CI as test cases. Some mechanics are introduced to really test with the (almost) original jlcons.