Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more information in banner for dev version #3687

Merged
merged 1 commit into from
May 4, 2024
Merged

Conversation

thofma
Copy link
Collaborator

@thofma thofma commented May 3, 2024

For reasons of space I had to remove the "Version" for the line. Here is how it looks:

  ___   ____   ____    _    ____
 / _ \ / ___| / ___|  / \  |  _ \   |  Combining ANTIC, GAP, Polymake, Singular
| | | |\___ \| |     / _ \ | |_) |  |  Type "?Oscar" for more information
| |_| | ___) | |___ / ___ \|  _ <   |  Manual: https://docs.oscar-system.org
 \___/ |____/ \____/_/   \_\_| \_\  |  1.1.0-DEV #master 0e79592 2024-05-03

It looks good with branch names that are not too long. I did not try to shorten the branch names to fit the 80 character limit (@antonydellavecchia was this name created automatically? If so, which tool?):

  ___   ____   ____    _    ____
 / _ \ / ___| / ___|  / \  |  _ \   |  Combining ANTIC, GAP, Polymake, Singular
| | | |\___ \| |     / _ \ | |_) |  |  Type "?Oscar" for more information
| |_| | ___) | |___ / ___ \|  _ <   |  Manual: https://docs.oscar-system.org
 \___/ |____/ \____/_/   \_\_| \_\  |  1.1.0-DEV #3632-currently-the-function-grassmann_pluecker_ideal-returns-an-ideal-in-a-non-graded-polynomial-ring-shouldnt-we-rather-use-a-standard-graded-ring 4430dd9 2024-04-24

I could spend more time and use .. for long branch names, but this can be added later.

Closes #3680.

P.S.: I decided against printing the "x days old", since there is no space and I did not want to pull in Base.Dates for the dates arithmetic.

@thofma thofma requested review from fingolfin and benlorenz May 3, 2024 16:58
Copy link

codecov bot commented May 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 83.12%. Comparing base (0e79592) to head (129e421).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3687      +/-   ##
==========================================
+ Coverage   82.70%   83.12%   +0.41%     
==========================================
  Files         577      577              
  Lines       78288    78329      +41     
==========================================
+ Hits        64749    65109     +360     
+ Misses      13539    13220     -319     
Files Coverage Δ
src/Oscar.jl 67.53% <0.00%> (-4.69%) ⬇️

... and 38 files with indirect coverage changes

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@thofma thofma merged commit 006e9a3 into master May 4, 2024
30 checks passed
@thofma thofma deleted the th/banner branch May 4, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Banner could show more information when version is "DEV"
3 participants