Use new is_terse and terse functions #3690
Conversation
|
The printing part of the dev docs need to be adapted as well; just applying your script led to some inconsistencies. |
| @@ -1390,7 +1390,7 @@ end | |||
| function Base.show(io::IO, m::MIME"text/plain", a::RelativeBrauerGroupElem) | |||
| io = pretty(io) | |||
| print(io, "Element of relative Brauer group of ", Lowercase(), parent(a).k) | |||
| io = IOContext(io, :supercompact => true, :compact => true) | |||
| io = terse(io) | |||
There was a problem hiding this comment.
This no longer setting :compact makes the lhs of the below list print verbose, as https://github.com/thofma/Hecke.jl/blob/master/src/NumFieldOrd/NfOrd/Ideal/Ideal.jl#L148 does not use is_terse. There are some more occurrences in this file still using :compact and thus producing weird results.
This is the reason for failing doctests.
There was a problem hiding this comment.
I'll add the compact back here, and then will have a look at replacing uses of compact in Hecke (so we can drop compact here in a future PR)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3690 +/- ##
==========================================
- Coverage 83.16% 83.16% -0.01%
==========================================
Files 579 579
Lines 78474 78475 +1
==========================================
Hits 65264 65264
- Misses 13210 13211 +1
|
|
CI is green now |
|
I've also changed the references to The only references to |
No description provided.