booktest: explicitly destroy mongodb db and client #3963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## sb/fix_bookchapter #3963 +/- ##
======================================================
+ Coverage 83.71% 84.20% +0.48%
======================================================
Files 592 591 -1
Lines 81572 81375 -197
======================================================
+ Hits 68289 68521 +232
+ Misses 13283 12854 -429 |
|
With the explicit destroy the tests went through (including vinberg2): https://github.com/oscar-system/Oscar.jl/actions/runs/10062115932/job/27813830951?pr=3963 Now trying with a less hacky way by just reassigning the variables. The reason why this did no appear earlier is that the new tests cause the db connection to timeout which causes an issue with atexit hooks (for the global |
Merged
fingolfin
pushed a commit
that referenced
this pull request
Jul 24, 2024
* fix booktests for vinberg_3.jlcon and move it to vinberg_2.jlcon * remove vinberg from ordered_examples.json * fix tests * suppress printing of unstable outputs * booktest: explicitly destroy mongodb db and client (#3963) * booktest: explicitly destroy mongodb db and client * booktest-polydb-cleanup: try nicer cleanup --------- Co-authored-by: Benjamin Lorenz <[email protected]>
ooinaruhugh
pushed a commit
to ooinaruhugh/Oscar.jl
that referenced
this pull request
Jul 31, 2024
* fix booktests for vinberg_3.jlcon and move it to vinberg_2.jlcon * remove vinberg from ordered_examples.json * fix tests * suppress printing of unstable outputs * booktest: explicitly destroy mongodb db and client (oscar-system#3963) * booktest: explicitly destroy mongodb db and client * booktest-polydb-cleanup: try nicer cleanup --------- Co-authored-by: Benjamin Lorenz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this helps for #3961
Note: this PR targets: #3939