Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump GAP.jl to 0.13 #4421

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

lgoettgens
Copy link
Member

@lgoettgens lgoettgens commented Jan 7, 2025

as a draft for now until GAP.jl 0.13.0 is released.

cc @fingolfin @ThomasBreuer

Resolves #3967
Resolves #4032
Closes #4132

@lgoettgens lgoettgens force-pushed the lg/GAP.jl-0.13 branch 7 times, most recently from a231c49 to 9b78dfa Compare January 7, 2025 11:44
@lgoettgens

This comment was marked as outdated.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.41%. Comparing base (9627744) to head (0e1a41f).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4421   +/-   ##
=======================================
  Coverage   84.41%   84.41%           
=======================================
  Files         668      668           
  Lines       88598    88590    -8     
=======================================
- Hits        74786    74780    -6     
+ Misses      13812    13810    -2     
Files with missing lines Coverage Δ
src/Oscar.jl 66.21% <ø> (-3.30%) ⬇️

... and 1 file with indirect coverage changes

src/Oscar.jl Outdated Show resolved Hide resolved
@lgoettgens lgoettgens closed this Jan 9, 2025
@lgoettgens lgoettgens reopened this Jan 9, 2025
@lgoettgens lgoettgens closed this Jan 9, 2025
@lgoettgens lgoettgens reopened this Jan 9, 2025
@lgoettgens lgoettgens closed this Jan 11, 2025
@lgoettgens lgoettgens reopened this Jan 11, 2025
@lgoettgens lgoettgens force-pushed the lg/GAP.jl-0.13 branch 2 times, most recently from 0d64ece to 5003a1e Compare January 13, 2025 15:10
test/Aqua.jl Outdated Show resolved Hide resolved
@lgoettgens lgoettgens marked this pull request as ready for review January 13, 2025 22:43
@lgoettgens lgoettgens merged commit e993383 into oscar-system:master Jan 14, 2025
29 of 31 checks passed
@lgoettgens lgoettgens deleted the lg/GAP.jl-0.13 branch January 14, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants