Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blow up along minimal supercone coordinates #4437

Conversation

paemurru
Copy link
Contributor

@paemurru paemurru commented Jan 9, 2025

The ray along which we blow up is given in fan-independent coordinates.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.39%. Comparing base (3505630) to head (fcd5923).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4437   +/-   ##
=======================================
  Coverage   84.39%   84.39%           
=======================================
  Files         663      663           
  Lines       87939    87963   +24     
=======================================
+ Hits        74216    74239   +23     
- Misses      13723    13724    +1     
Files with missing lines Coverage Δ
...erimental/Schemes/src/ToricBlowups/constructors.jl 91.04% <100.00%> (+1.21%) ⬆️
src/PolyhedralGeometry/PolyhedralFan/properties.jl 98.42% <100.00%> (+0.24%) ⬆️

... and 5 files with indirect coverage changes

src/PolyhedralGeometry/PolyhedralFan/properties.jl Outdated Show resolved Hide resolved
src/exports.jl Outdated Show resolved Hide resolved
@lgoettgens lgoettgens added topic: polyhedral geometry Issue concerns polyhedral geometry code topic: toric varieties labels Jan 10, 2025
@lgoettgens lgoettgens requested a review from HereAround January 10, 2025 13:01
Copy link
Member

@HereAround HereAround left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @paemurru !

@HereAround HereAround merged commit 80a253f into oscar-system:master Jan 10, 2025
29 of 31 checks passed
@paemurru paemurru deleted the ep/blow_up_along_minimal_supercone_coordinates branch January 10, 2025 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: polyhedral geometry Issue concerns polyhedral geometry code topic: toric varieties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants