-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blow up along minimal supercone coordinates #4437
Merged
HereAround
merged 6 commits into
oscar-system:master
from
paemurru:ep/blow_up_along_minimal_supercone_coordinates
Jan 10, 2025
Merged
Blow up along minimal supercone coordinates #4437
HereAround
merged 6 commits into
oscar-system:master
from
paemurru:ep/blow_up_along_minimal_supercone_coordinates
Jan 10, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ray along which we blow up is given in a fan-independent way.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4437 +/- ##
=======================================
Coverage 84.39% 84.39%
=======================================
Files 663 663
Lines 87939 87963 +24
=======================================
+ Hits 74216 74239 +23
- Misses 13723 13724 +1
|
lgoettgens
reviewed
Jan 10, 2025
lgoettgens
added
topic: polyhedral geometry
Issue concerns polyhedral geometry code
topic: toric varieties
labels
Jan 10, 2025
Co-authored-by: Lars Göttgens <[email protected]>
HereAround
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thank you @paemurru !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ray along which we blow up is given in fan-independent coordinates.