Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PolyhedralGeometry: added visualize(::Vector) docu #4449

Merged
merged 1 commit into from
Jan 13, 2025
Merged

PolyhedralGeometry: added visualize(::Vector) docu #4449

merged 1 commit into from
Jan 13, 2025

Conversation

YueRen
Copy link
Member

@YueRen YueRen commented Jan 11, 2025

see title

@lgoettgens lgoettgens added documentation Improvements or additions to documentation topic: polyhedral geometry Issue concerns polyhedral geometry code labels Jan 11, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.42%. Comparing base (a60b0d8) to head (e86d28c).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4449      +/-   ##
==========================================
- Coverage   84.42%   84.42%   -0.01%     
==========================================
  Files         668      668              
  Lines       88363    88363              
==========================================
- Hits        74600    74599       -1     
- Misses      13763    13764       +1
Files with missing lines Coverage Δ
src/PolyhedralGeometry/visualization.jl 37.93% <ø> (ø)

... and 1 file with indirect coverage changes

benlorenz
benlorenz approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@benlorenz benlorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@benlorenz benlorenz merged commit e40f40f into master Jan 13, 2025
30 of 32 checks passed
@benlorenz benlorenz deleted the yr/visualizeDocu branch January 13, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benlorenz benlorenz benlorenz approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation topic: polyhedral geometry Issue concerns polyhedral geometry code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YueRen @benlorenz @lgoettgens