[FTheoryTools] Reduce allocs #4453
Open
+72
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HereAround
added
topic: FTheoryTools
optimization
lgoettgens
reviewed
Jan 11, 2025
HereAround
force-pushed
the
LessAllocs
branch
from
8250f1c to
90bee65
Compare
HereAround
force-pushed
the
LessAllocs
branch
3 times, most recently
from
3c10bba to
1211766
Compare
fingolfin
reviewed
Jan 12, 2025
| # Check for non-Abelian gauge group breaking | ||
| if has_attribute(g4, :breaks_non_abelian_gauge_group) | ||
| if breaks_non_abelian_gauge_group(g4) | ||
| push!(properties_string, " - Non-Abelian gauge group: broken") |
There was a problem hiding this comment.
Just out of curiosity, why Non-Abelian and not the more usual non-abelian?
There was a problem hiding this comment.
As a humble PhD student, @mohamed-barakat once showed me his (at the time) writing style for proposals, in which the capitalized the name of Mathematicians to honor their contributions. In the case at hand, Abel. I believe this style stayed with me since, although I am sure to have been inconsistent.
On second look, I favor non-abelian here. More consistent. Will update this shortly.
fingolfin
reviewed
Jan 12, 2025
HereAround
force-pushed
the
LessAllocs
branch
from
d91377a to
852dbd5
Compare
Co-authored-by: Lars Göttgens <[email protected]>
Co-authored-by: Max Horn <[email protected]>
HereAround
force-pushed
the
LessAllocs
branch
from
852dbd5 to
1f663da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For my convenience, based on #4446.
cc @apturner @emikelsons