Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BasisLieHighestWeight: Rename some variables in doctests #4461

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

lgoettgens
Copy link
Member

As per request of @gfourier.

The previous code raised the following error when copy-pasted in a session after using Oscar:

ERROR: cannot assign a value to imported variable Oscar.bases from module Main
Stacktrace:
 [1] top-level scope
   @ REPL[13]:1

Renaming the local variable gets rid of this issue and makes it easier for people to play around with the code

@lgoettgens lgoettgens added documentation Improvements or additions to documentation topic: LieTheory experimental Only changes experimental parts of the code labels Jan 13, 2025
@lgoettgens lgoettgens enabled auto-merge (squash) January 13, 2025 16:21
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.41%. Comparing base (7219bae) to head (5b85f83).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4461   +/-   ##
=======================================
  Coverage   84.41%   84.41%           
=======================================
  Files         668      668           
  Lines       88441    88441           
=======================================
  Hits        74656    74656           
  Misses      13785    13785           
Files with missing lines Coverage Δ
...imental/BasisLieHighestWeight/src/UserFunctions.jl 92.30% <ø> (ø)

@lgoettgens lgoettgens merged commit 9627744 into oscar-system:master Jan 13, 2025
29 of 31 checks passed
@lgoettgens lgoettgens deleted the lg/BasisLie-doctest-vars branch January 13, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation experimental Only changes experimental parts of the code topic: LieTheory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants