Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.jl: refactor how we invoke configure #109

Merged
merged 2 commits into from
Jun 20, 2019

Conversation

fingolfin
Copy link
Member

With the new variant, it's trivial to keep the debug and non-debug settings in
sync; also, if people add or remove configure options, that is now easy to see
in a diff.

Motivated by reviewing PR #104 by @sebasguts ;-)

With the new variant, it's trivial to keep the debug and non-debug settings in
sync; also, if people add or remove configure options, that is now easy to see
in a diff.
@wbhart
Copy link
Contributor

wbhart commented Jun 19, 2019

Thanks for this. I'm reluctant to merge it just yet until our tests are passing again though. I will wait until then and come back to this.

@fingolfin
Copy link
Member Author

Of course, that makes perfect sense, I wouldn't expect anything else (I was in fact kinda relying on the CI tests to fully verify what I did here)

@fingolfin fingolfin mentioned this pull request Jun 19, 2019
40 tasks
deps/build.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #109 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #109   +/-   ##
=====================================
  Coverage       0%     0%           
=====================================
  Files          30     30           
  Lines        2588   2588           
=====================================
  Misses       2588   2588

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e0595f...972a2b9. Read the comment docs.

@wbhart wbhart merged commit ea3e4af into oscar-system:master Jun 20, 2019
@fingolfin fingolfin deleted the mh/build.jl branch June 21, 2019 09:24
fingolfin pushed a commit to fingolfin/Singular.jl that referenced this pull request Jun 6, 2023
build.jl: refactor how we invoke configure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants