Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release github actions ci #70

Open
oscarmorrison opened this issue Jan 31, 2024 · 6 comments
Open

Fix release github actions ci #70

oscarmorrison opened this issue Jan 31, 2024 · 6 comments

Comments

@oscarmorrison
Copy link
Owner

          @p1ho any chance you can please have a look at this, seems to be an issue from the automation

Originally posted by @oscarmorrison in #64 (comment)

@p1ho
Copy link
Collaborator

p1ho commented Feb 2, 2024

@oscarmorrison Hello! My apologies, but I don't currently have capacity to fix this, but I have some ideas.

Before I start, I see that the action yml file has been deleted in #68; given the amount of contribution traffic is low, I believe we should be fine going forward without the GitHub action scripts.

I believe the root cause has to do with the branch name set in my original PR #42. Currently the default branch name is main, but in my test run it was actually on master (link), so if we change this line to using: ad-m/github-push-action@main, it could be the fix.

Was the branch name always main? If so it must have been my oversight, sorry about that!
If the script is working, then in the default branch of this PR, after every single merge there should be an automated commit that looks like the following.
image

@Swamptin
Copy link

Swamptin commented Apr 3, 2024

Hi, I was just looking at this project in order to implement it for my own blog and saw this open issue.
If it's just a case of re-instating the release.yml file in .github/workflows/ with the correct branch name I'm happy to do that and submit a PR for it.

@oscarmorrison
Copy link
Owner Author

oscarmorrison commented Apr 4, 2024 via email

@Swamptin
Copy link

Swamptin commented Apr 4, 2024

Apologies for the silly question. I've the change made locally in the review branch. I can't push a commit, obviously that's rightly restricted. Would you like me to create a fork to create the PR for review off of, or is there something else I can do that I'm not aware of?
Appreciate the pointers.

@oscarmorrison
Copy link
Owner Author

oscarmorrison commented Apr 5, 2024 via email

@Swamptin
Copy link

Swamptin commented Apr 5, 2024

Hi @oscarmorrison, I took a shot at it last night. It's PR #74. Let me know if there's anything you want me to do different.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants