-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix release github actions ci #70
Comments
@oscarmorrison Hello! My apologies, but I don't currently have capacity to fix this, but I have some ideas. Before I start, I see that the action yml file has been deleted in #68; given the amount of contribution traffic is low, I believe we should be fine going forward without the GitHub action scripts. I believe the root cause has to do with the branch name set in my original PR #42. Currently the default branch name is Was the branch name always |
Hi, I was just looking at this project in order to implement it for my own blog and saw this open issue. |
Excellent. Thankyou
…On Thu, 4 Apr 2024 at 9:43 am, Swamptin ***@***.***> wrote:
Hi, I was just looking at this project in order to implement it for my own
blog and saw this open issue.
If it's just a case of re-instating the release.yml file in
.github/workflows/ with the correct branch name I'm happy to do that and
submit a PR for it.
—
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMTEDH5TVUDOZSX6HRICFTY3SAXPAVCNFSM6AAAAABCT4SGFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZVG4ZTAMRXGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Apologies for the silly question. I've the change made locally in the review branch. I can't push a commit, obviously that's rightly restricted. Would you like me to create a fork to create the PR for review off of, or is there something else I can do that I'm not aware of? |
…scarmorrison#70. Incremented version to 1.0.1 in package.json
Yes you need to make a fork.
This might help you:
https://github.com/firstcontributions/first-contributions
…On Fri, 5 Apr 2024 at 9:16 am, Swamptin ***@***.***> wrote:
Apologies for the silly question. I've the change made locally in the
review branch. I can't push a commit, obviously that's rightly restricted.
Would you like me to create a fork to create the PR for review off of, or
is there something else I can do that I'm not aware of?
Appreciate the pointers.
—
Reply to this email directly, view it on GitHub
<#70 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMTEDF2JQ6EUZK7VOYIPBTY3XGLLAVCNFSM6AAAAABCT4SGFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZYGMZTSNRXHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Hi @oscarmorrison, I took a shot at it last night. It's PR #74. Let me know if there's anything you want me to do different. |
Originally posted by @oscarmorrison in #64 (comment)
The text was updated successfully, but these errors were encountered: