Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes tests and part of the CI pipeline #62

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Fixes tests and part of the CI pipeline #62

merged 1 commit into from
Apr 3, 2023

Conversation

StefanoCappellini
Copy link
Collaborator

@StefanoCappellini StefanoCappellini commented Jan 11, 2023

This should fix #60

  • Introduces the test-ci command for npm, removing the --watchAll options that caused the pipeline to hang
  • Splits the test pipeline commands, thus they can be easily inspected
  • Inside the test.yml, it performs the build before the test, because tests DEPEND ON the md-page artifact
  • Adds workflow_dispatch for the test pipeline
  • Updates the DEV_README

We should, however, discuss the point of the --watchAll if we are testing the build artifact. Should we test (at least on dev) the script itself directly, or should we discourage the --watchAll?

Let me know

Copy link
Owner

@oscarmorrison oscarmorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oscarmorrison oscarmorrison merged commit eb858d1 into oscarmorrison:main Apr 3, 2023
@oscarmorrison oscarmorrison mentioned this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm run test fails: 18 snapshots failed.
2 participants