Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help & About menu always be white color #521

Closed
Bambooin opened this issue Sep 7, 2021 · 3 comments · Fixed by #533
Closed

Help & About menu always be white color #521

Bambooin opened this issue Sep 7, 2021 · 3 comments · Fixed by #533

Comments

@Bambooin
Copy link
Collaborator

Bambooin commented Sep 7, 2021

Describe the bug
Help & About menu always white color

To Reproduce
Steps to reproduce the bug:

  1. Go to 'Other'
  2. Click on 'Night Mode'
  3. Select 'Dark'
  4. See bug

Expected behavior
Help & About menu should be dark mode

Log

Screenshots

Smartphone (please complete the following information):

  • Device: [Redmi]
  • OS: [Android 11]
  • Version: [3.2.2]

Additional context
@WhiredPlanck
Copy link
Collaborator

WhiredPlanck commented Sep 7, 2021 •
edited
Loading

This is a design on purpose, not a bug. If the menu follow the night mode, it may be not very clear to read, IMO.

@Bambooin
Copy link
Collaborator Author

Bambooin commented Sep 8, 2021

LineageOS 18.1

  • Files: it's lighter black color in dark theme.
  • Messaging: same too.
  • Phone: same too.

@WhiredPlanck
Copy link
Collaborator

LineageOS 18.1

* Files: it's lighter black color in dark theme.

* Messaging: same too.

* Phone: same too.

Quiet useful information. I'll change it.

WhiredPlanck added a commit to WhiredPlanck/trime-new that referenced this issue Sep 21, 2021
@WhiredPlanck
res: make Options Menu follow the UI mode (osfans#521)
73205ba
WhiredPlanck added a commit to WhiredPlanck/trime-new that referenced this issue Sep 21, 2021
@WhiredPlanck
fix(res): make Options Menu follow the UI mode (osfans#521)
eea722f
@WhiredPlanck WhiredPlanck mentioned this issue Sep 22, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve servey 20210917 WhiredPlanck/trime-new
2 participants
@Bambooin @WhiredPlanck