-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doesn't print correct logger name with kotlin-logging-js 4.0.0-beta-19 #279
Comments
Thank you for reporting an issue. See the wiki for documentation and slack for questions. |
Thanks for reporting, I created a test + fix in #280. |
* fix logger name in messages * add back console appender * make tests pass in browser * fix native * Add js Test Issue #279
Fixed in 4.0.0-beta-20. |
|
My workaround
|
The 3.0.5 impl was doing something like this:
From what I observed this doesn't work well in all cases. So not sure it ever worked for all cases(browser/node). |
Thanks! I added the suggested code in #283 |
with
|
Thanks for your very fast reply! Handling this thing in JS is very difficult, as it's not designed for reflection and similar things we have in JVM :-). |
I have error while reloading gradle project with "4.0.0-beta-21".
|
Run task Tried both below, same error. |
Please try again, because I do see the version on maven, might be caching (of error) issue: https://repo1.maven.org/maven2/io/github/oshai/kotlin-logging-js/4.0.0-beta-21/ |
Not sure if it's related but I am using JS LEGACY mode because the new IR has performance issue. Then I tried multiple options below.
Download https://repo.maven.apache.org/maven2/io/github/oshai/kotlin-logging-js/4.0.0-beta-20/kotlin-logging-js-4.0.0-beta-20.jar, took 91 ms (16,67 kB) This is the directory at ~.gradle\caches\modules-2\files-2.1\io.github.oshai
Download https://repo.maven.apache.org/maven2/io/github/oshai/kotlin-logging-js/4.0.0-beta-20/kotlin-logging-js-4.0.0-beta-20.jar, took 83 ms (16,67 kB) This is the directory at ~.gradle\caches\modules-2\files-2.1\io.github.oshai
Download https://repo.maven.apache.org/maven2/io/github/oshai/kotlin-logging/4.0.0-beta-21/kotlin-logging-4.0.0-beta-21-sources.jar, took 180 ms (51,99 kB) This is the directory at ~.gradle\caches\modules-2\files-2.1\io.github.oshai
Nothing is downloaded. Failed building KotlinMPPGradleModel |
Probably related, as I changed to the new IR (there was a warning, BOTH is deprecated). I can change back if needed. |
Please support both until the new IR is really the way to go. |
ok, I am releasing |
Cool!, Thank you a lot! |
Code
implementation("io.github.oshai:kotlin-logging-js:4.0.0-beta-19")
Output in Chrome console:
DEBUG: [DEBUG] myFunc
implementation("io.github.microutils:kotlin-logging-js:3.0.5")
Output in Chrome console:
DEBUG: [MyClass] myFunc
The text was updated successfully, but these errors were encountered: